-
Notifications
You must be signed in to change notification settings - Fork 1
Archive build before deploy #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReplaces Vercel deploy packaging with the split-tgz archive option and adds a comment referencing the Vercel changelog in both preview and production GitHub Actions workflows. No other workflow steps or public API/signatures changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant CLI as Vercel CLI
participant API as Vercel Platform
Dev->>GH: Push / Merge
GH->>CLI: Run `vercel deploy --prebuilt --archive=split-tgz` [--prod]
note right of CLI #f6f8ff: Package artifacts as split-tgz (new)
CLI->>API: Upload split-tgz archive & initiate deployment
API-->>GH: Deployment status (URL / success / error)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/deploy_preview.yml (2)
39-41: Make deploy fully non-interactive in CI with --yes.The CLI can prompt on first-time setups; adding
--yeskeeps the step deterministic.
Apply:- run: vercel deploy --prebuilt --archive=tgz --token=${{ secrets.VERCEL_TOKEN }} + run: vercel deploy --prebuilt --archive=tgz --yes --token=${{ secrets.VERCEL_TOKEN }}
39-41: If you hit upload limits or slow uploads, consider split-tgz.Vercel introduced
--archive=split-tgz(Jan 16, 2025) to bypass single-file size limits and speed up large prebuilt uploads (~up to 30% faster). Optional switch if your build output is huge.Example:
- run: vercel deploy --prebuilt --archive=tgz --token=${{ secrets.VERCEL_TOKEN }} + run: vercel deploy --prebuilt --archive=split-tgz --yes --token=${{ secrets.VERCEL_TOKEN }}.github/workflows/deploy_production.yml (2)
37-39: Add --yes for non-interactive prod deploys.Prevents any unexpected prompts during production releases.
- run: vercel deploy --prebuilt --archive=tgz --prod --token=${{ secrets.VERCEL_TOKEN }} + run: vercel deploy --prebuilt --archive=tgz --prod --yes --token=${{ secrets.VERCEL_TOKEN }}
37-39: Option: switch to split-tgz for very large artifacts.If production bundles are massive or deployments are hitting upload limits,
--archive=split-tgzcan help.- run: vercel deploy --prebuilt --archive=tgz --prod --token=${{ secrets.VERCEL_TOKEN }} + run: vercel deploy --prebuilt --archive=split-tgz --prod --yes --token=${{ secrets.VERCEL_TOKEN }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/deploy_preview.yml(1 hunks).github/workflows/deploy_production.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/deploy_preview.yml (1)
39-41: LGTM: Using tgz archive with prebuilt deploys is correct and supported.This reduces file-count uploads and helps avoid rate limits for large prebuilt outputs. Official docs show the exact pattern:
vercel deploy --prebuilt --archive=tgz. (vercel.com).github/workflows/deploy_production.yml (1)
37-39: LGTM: Aligning production deploy with tgz archive is a good move.Matches the preview workflow and follows the documented
--archive=tgzusage for prebuilt deployments. (vercel.com)
1d648a9 to
83fc6f9
Compare
Summary by CodeRabbit